Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under Windows builds are forced to release mode #779

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

veloman-yunkan
Copy link
Collaborator

@veloman-yunkan veloman-yunkan commented Nov 22, 2024

Fixes #757

base_deps_meta_version was bumped so that the base dependencies archives for CI workflows are recreated (we need only the Windows flavours of the archives updated but such surgical intervention is not supported).

base_deps_meta_version was bumped so that the base dependencies archives for CI
workflows are recreated (we need only the Windows flavours of the
archives updated but such surgical intervention is not supported).
@veloman-yunkan veloman-yunkan force-pushed the windows_builds_in_release_mode branch from 84a742f to 1c69945 Compare November 22, 2024 15:59
@veloman-yunkan veloman-yunkan marked this pull request as ready for review November 22, 2024 17:51
@veloman-yunkan
Copy link
Collaborator Author

The following fragment of README of libzim repo will need to be updated:

Please notice that on Microsoft Windows with Microsoft compiler, you need to be careful to not compile in debug mode (because our released binaries are not). If you want to compile with the debug flag /MDd, then please use our nightlies.

@kelson42 kelson42 merged commit 8c3ba3f into main Nov 22, 2024
40 checks passed
@kelson42 kelson42 deleted the windows_builds_in_release_mode branch November 22, 2024 18:29
veloman-yunkan added a commit to openzim/libzim that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable DEBUG for Windows nightly
2 participants